meludame: zombie-walking stick figure of a man with the text "must have coffee!" in all caps. (Default)
[personal profile] meludame
Description:

In #tertiary, the borders for .module-time and .module-powered are bigger than the container they're in because modules are bigger than the container they're in due to use of padding instead of margin and excessive values.

Proposed fix:

Edit CSS to make the divs behave.

Files edited:
  • styles/brittle/layer.s2.

Bug Diary:

First order of business was to use firefox's built in inspector to make the problem more apparent. Once that was done, the inspection revealed that .module-tags_cloud also suffered from the same problem.

All the modules in #tertiary are floated which allows for them to break out of their container if they are too wide. The three modules concerned have their width declared together in the following rule: .module-powered, .module-tags_cloud, .module-time { width: 90%;}

An easy solution is to un-float those three modules and set their width automatically. Another is to slightly lower the width set in the CSS to amount for the padding. The later solution only requires one line changed but wouldn't ensure that it'd be the correct width accross all themes.

How to revert the changes made:

#tertiary .module-powered,  
#tertiary .module-tags_cloud,  
#tertiary .module-time {  
  clear: none;  
  float: left;  
  width: 90%;  
}
Notes, tips and assorted blooper reels:

The correct way to abort amending a commit, is to erase all the commit message and save before exiting. Git will complain and not commit the changes because all commits must have a message.

/!\ Use with caution: Resetting the develop branch to its proper state:

  1. checkout the develop branch on you 'hack'
  2. use the git reset --hard origin/develop

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

Profile

meludame: zombie-walking stick figure of a man with the text "must have coffee!" in all caps. (Default)
meludame

July 2013

S M T W T F S
 123456
7891011 1213
14151617181920
21222324 25 2627
28293031   

Most Popular Tags

Style Credit

Expand Cut Tags

No cut tags
Page generated Jun. 21st, 2025 12:56 am
Powered by Dreamwidth Studios